Add linting for unused parameters #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
karmada-bot
requested review from
carlory,
chaosi-zju,
jwcesign,
pigletfly and
Poor12
karmada-bot
added
the
size/S
Affan-7
force-pushed
the
lint-unused-param
branch
from
8460890
to
c898017
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4512 +/- ##
==========================================
+ Coverage 51.86% 51.87% +0.01%
==========================================
Files 243 243
Lines 24183 24183
==========================================
+ Hits 12543 12546 +3
+ Misses 10959 10957 -2
+ Partials 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RainbowMango
reviewed
Jan 4, 2024
pkg/controllers/multiclusterservice/endpointslice_collect_controller.go
Outdated
Show resolved
Hide resolved
23 tasks
Affan-7
commented
Jan 10, 2024
jwcesign
reviewed
Jan 10, 2024
Affan-7
force-pushed
the
lint-unused-param
branch
2 times, most recently
from
644e15f
to
b25fee1
Compare
Signed-off-by: Mohammed Affan <mohammed.affan.727@gmail.com>
Affan-7
force-pushed
the
lint-unused-param
branch
from
b25fee1
to
970435c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR enables linting for the unused parameters in the functions.
Which issue(s) this PR fixes:
Part of #4490
Does this PR introduce a user-facing change?: