Skip to content

Bump Kubernetes dependencies to v1.28.5 #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 25, 2023
Merged

Bump Kubernetes dependencies to v1.28.5 #4463

merged 2 commits into from
Dec 25, 2023

Conversation

RainbowMango
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR updates Kubernetes dependencies to v1.28.5.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This PR adopted the following changes:

Does this PR introduce a user-facing change?:

Kubernetes dependencies now have been bumped to v1.28.5.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 21, 2023
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ffe976) 51.87% compared to head (99d4130) 51.86%.

Files Patch % Lines
pkg/search/proxy/store/store.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4463      +/-   ##
==========================================
- Coverage   51.87%   51.86%   -0.02%     
==========================================
  Files         243      243              
  Lines       24177    24179       +2     
==========================================
- Hits        12543    12541       -2     
- Misses      10953    10956       +3     
- Partials      681      682       +1
Flag Coverage Δ
unittests 51.86% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng liangyuanpeng mentioned this pull request Dec 21, 2023
Merged
RainbowMango
RainbowMango commented Dec 21, 2023
View reviewed changes
pkg/search/proxy/store/store.go
Comment on lines +194 to +198
// RequestWatchProgress implements storage.Interface.
func (s *store) RequestWatchProgress(context.Context) error {
return fmt.Errorf("not implemented")
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XiShanYongYe-Chang @ikaven1024 @xigang
Can you help to confirm if it OK to leave this interface unimplemented?
This interface was introduced by kubernetes/kubernetes#119207.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By examining the calling path of the code, confirm that the current return of error has no impact.

Test in the environment, and verify that the search function is working properly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

RainbowMango
RainbowMango commented Dec 21, 2023
View reviewed changes
@RainbowMango RainbowMango force-pushed the pr_update_kube_1285 branch 2 times, most recently from 948b12a to 7503587 Compare December 22, 2023 09:17
@RainbowMango RainbowMango mentioned this pull request Dec 22, 2023
Merged
@RainbowMango
Bump Kubernetes dependencies to v1.28.5
abba80d 
Adopts changes made by kubernetes#119207, implements RequestWatchProgress interface
Adopts changes made by kubernetes#116648, applyTo take in clients

Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango
update auto-generated files
99d4130 
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango mentioned this pull request Dec 25, 2023
Closed
@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 25, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit 715d46c into karmada-io:master Dec 25, 2023
@RainbowMango RainbowMango deleted the pr_update_kube_1285 branch March 30, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@ikaven1024 ikaven1024 Awaiting requested review from ikaven1024

@Poor12 Poor12 Awaiting requested review from Poor12

@XiShanYongYe-Chang XiShanYongYe-Chang Awaiting requested review from XiShanYongYe-Chang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RainbowMango @codecov-commenter @karmada-bot @XiShanYongYe-Chang