fix: Update RB once new clusters are added to trigger the propagation of service to these new clusters #4423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of service to these new clusters Signed-off-by: jwcesign <jwcesign@gmail.com>
karmada-bot
added
the
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4423 +/- ##
==========================================
- Coverage 51.89% 51.88% -0.01%
==========================================
Files 243 243
Lines 24162 24162
==========================================
- Hits 12538 12537 -1
Misses 10943 10943
- Partials 681 682 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When new clusters are joined, we should propagate the service to the new clusters.
Before, if the providerClusters/consumerClusters are empty, there was no modification even new clusters are joined.
In this scenario, the scheduler will not schedule the service to the newly joined clusters.
So we should update the RB to trigger it.
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: