feat: fix resource(work/resource in member clusters) conflicting between PP and MCS. #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/api-change
karmada-bot
requested review from
chaosi-zju,
chaunceyjiang,
Garrybest,
mrlihanbo,
Poor12 and
XiShanYongYe-Chang
karmada-bot
added
the
size/XXL
jwcesign
force-pushed
the
fix-pp-conflict
branch
from
2eef3b0 to
f0d8f88
Compare
karmada-bot
added
size/XL
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4414 +/- ##
==========================================
- Coverage 51.92% 51.89% -0.03%
==========================================
Files 243 243
Lines 24150 24162 +12
==========================================
- Hits 12539 12538 -1
- Misses 10930 10943 +13
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jwcesign
commented
Dec 13, 2023
jwcesign
force-pushed
the
fix-pp-conflict
branch
4 times, most recently
from
cf63989 to
63c22d2
Compare
jwcesign
force-pushed
the
fix-pp-conflict
branch
2 times, most recently
from
84d87d8 to
ea011b1
Compare
Comment on lines
+143
to
+144
| // EventReasonConfigurationRedundant indicates that MultiClusterService configuration redundant. | ||
| EventReasonConfigurationRedundant = "ConfigurationRedundant" |
| @@ -108,7 +108,8 @@ func (s *Scheduler) resourceBindingEventFilter(obj interface{}) bool { | |||
| } | |||
|
|
|||
| return util.GetLabelValue(accessor.GetLabels(), policyv1alpha1.PropagationPolicyNameLabel) != "" || | |||
| util.GetLabelValue(accessor.GetLabels(), policyv1alpha1.ClusterPropagationPolicyLabel) != "" | |||
| util.GetLabelValue(accessor.GetLabels(), policyv1alpha1.ClusterPropagationPolicyLabel) != "" || | |||
| util.GetLabelValue(accessor.GetLabels(), workv1alpha2.BindingManagedByLabel) != "" | |||
There was a problem hiding this comment.
TODO: consider a new label name.
jwcesign
commented
Dec 14, 2023
pkg/controllers/multiclusterservice/endpointslice_dispatch_controller.go
Outdated
Show resolved
Hide resolved
jwcesign
force-pushed
the
fix-pp-conflict
branch
2 times, most recently
from
6f3632f to
cefd90e
Compare
Signed-off-by: jwcesign <jwcesign@gmail.com>
jwcesign
commented
Dec 14, 2023
jwcesign
force-pushed
the
fix-pp-conflict
branch
from
cefd90e to
467e666
Compare
jwcesign
changed the title
jwcesign
changed the title
jwcesign
commented
Dec 14, 2023
jwcesign
force-pushed
the
fix-pp-conflict
branch
from
467e666 to
e77fe55
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
Previously, we directly generated service work, but this led to conflicts with work created based on RB/PP. To resolve this issue, we introduced a new naming style for the work.
To prevent these conflicts, we propose a solution: MCS will generate RB from the service and if there's an existing RB generated by PP, MCS will assume control over it. This way, no conflict arises. Additionally, once a resource is matched by MCS, the detector should ignore it.
Looking ahead, other CRs similar to MCS(like a scenario-related PP) may emerge in future scenarios. They should adhere to this approach to avoid potential conflicts.
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: