-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
register cluster install karmada-agent should set leader-elect-resouce-namespace #4404
Conversation
…ce-namespace Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
/assign @chaunceyjiang |
Hi @yanfeng1992 can you help add a release note? |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ask @lonelyCZ or @chaunceyjiang to approve this patch.
Thanks~ /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaunceyjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yanfeng1992, do you think we need to cherry-pick this patch to the previous branch? |
I don't think it's necessary, the problem doesn't seem that serious |
What type of PR is this?
/kind bug
What this PR does / why we need it:
karmada agent deployment namespace and leader-elect-resouce-namespace should be consistent
now we install karmada agent in a new namespace, but leader-elect-resouce-namespace is karmada-system
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: