Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register cluster install karmada-agent should set leader-elect-resouce-namespace #4404

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

yanfeng1992
Copy link
Member

@yanfeng1992 yanfeng1992 commented Dec 12, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

karmada agent deployment namespace and leader-elect-resouce-namespace should be consistent

now we install karmada agent in a new namespace, but leader-elect-resouce-namespace is karmada-system

image

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`:  Register cluster install karmada-agent should set leader-elect-resouce-namespace.

…ce-namespace

Signed-off-by: huangyanfeng <huangyanfeng1992@gmail.com>
@karmada-bot karmada-bot requested a review from carlory December 12, 2023 12:46
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 12, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2023
@yanfeng1992
Copy link
Member Author

/assign @chaunceyjiang

@XiShanYongYe-Chang
Copy link
Member

Hi @yanfeng1992 can you help add a release note?

@yanfeng1992
Copy link
Member Author

Hi @yanfeng1992 can you help add a release note?

done

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@RainbowMango RainbowMango added this to the v1.9 milestone Dec 15, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Ask @lonelyCZ or @chaunceyjiang to approve this patch.

@XiShanYongYe-Chang
Copy link
Member

/cc @chaunceyjiang @RainbowMango

@chaunceyjiang
Copy link
Member

Thanks~

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaunceyjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@karmada-bot karmada-bot merged commit f8cdc40 into karmada-io:master Dec 21, 2023
12 checks passed
@yanfeng1992 yanfeng1992 deleted the agent-leader-ns branch December 21, 2023 08:32
@XiShanYongYe-Chang
Copy link
Member

Hi @yanfeng1992, do you think we need to cherry-pick this patch to the previous branch?

@yanfeng1992
Copy link
Member Author

Hi @yanfeng1992, do you think we need to cherry-pick this patch to the previous branch?

I don't think it's necessary, the problem doesn't seem that serious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants