-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make hook-delete-policy in helm job configurable #4393
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
==========================================
- Coverage 51.91% 51.90% -0.02%
==========================================
Files 243 243
Lines 24146 24146
==========================================
- Hits 12536 12532 -4
- Misses 10928 10931 +3
- Partials 682 683 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
99e30f3
to
9315b02
Compare
/lgtm |
@wengyao04: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks !! |
CC @RainbowMango ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Could we also make "helm.sh/hook-delete-policy": hook-succeeded configurable in post-install-job.yaml. We want to keep the job pod for debugging issues if post-install job fails
Which issue(s) this PR fixes:
Fixes part of #4368
Special notes for your reviewer:
Does this PR introduce a user-facing change?: