Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hook-delete-policy in helm job configurable #4393

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Dec 11, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Could we also make "helm.sh/hook-delete-policy": hook-succeeded configurable in post-install-job.yaml. We want to keep the job pod for debugging issues if post-install job fails

Which issue(s) this PR fixes:

Fixes part of #4368

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`Helm Chart`: Make hook-delete-policy in helm job configurable.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 11, 2023
@karmada-bot karmada-bot requested review from jrkeen and pidb December 11, 2023 06:31
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3482ee8) 51.91% compared to head (9315b02) 51.90%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4393      +/-   ##
==========================================
- Coverage   51.91%   51.90%   -0.02%     
==========================================
  Files         243      243              
  Lines       24146    24146              
==========================================
- Hits        12536    12532       -4     
- Misses      10928    10931       +3     
- Partials      682      683       +1     
Flag Coverage Δ
unittests 51.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@wengyao04
Copy link
Contributor

/lgtm

@karmada-bot
Copy link
Collaborator

@wengyao04: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wengyao04
Copy link
Contributor

Thanks !!

@chaosi-zju
Copy link
Member Author

CC @RainbowMango ready to merge

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2023
@karmada-bot karmada-bot merged commit 90bdfcb into karmada-io:master Dec 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants