-
Notifications
You must be signed in to change notification settings - Fork 960
feat: clean eps work of the provison cluster when pull clusters get unhealthy #4383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84fe487
to
eb8c0a1
Compare
/cc @Rains6 @XiShanYongYe-Chang @chaosi-zju |
@jwcesign: GitHub didn't allow me to request PR reviews from the following users: Rains6. Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4383 +/- ##
=======================================
Coverage 51.87% 51.87%
=======================================
Files 243 243
Lines 24114 24114
=======================================
+ Hits 12509 12510 +1
+ Misses 10923 10922 -1
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add/update the e2e for it
I will do it in another PR. Are u willing to add e2e for this PR? |
Signed-off-by: jwcesign <jwcesign@gmail.com>
eb8c0a1
to
090c1f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yes |
Yes, add to |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Before, the eps work's deletion of the provision clusters is handled by the agent(for pull clusters), when the cluster is disconnected, the karmada-agent can't delete the work, causing resource residue.
This PR moves the deletion to mcs_controller.go(always run on Karmada control plane), to fix the problem
Which issue(s) this PR fixes:
Fixes #none
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: