-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repair the cluster_status_controller_test #3948
Conversation
Just reminder, the test is failing:
|
yea, It is course by "race detected during execution of test", I need to make a analysis. |
c74a98e
to
2a8fb8e
Compare
}() | ||
wg.Wait() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lease controller will keep running and never stop in normal cases. Seems we don't need to wait for it to complete.
Signed-off-by: Tanggui Bian <softwarebtg@163.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3948 +/- ##
==========================================
+ Coverage 54.69% 54.83% +0.13%
==========================================
Files 229 229
Lines 22086 22086
==========================================
+ Hits 12080 12110 +30
+ Misses 9358 9324 -34
- Partials 648 652 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
After the controller runtime update here, test case need to be adapted.
Which issue(s) this PR fixes:
Fixes #3730
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
@RainbowMango @XiShanYongYe-Chang