ImageOverrider Implementation #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
3 times, most recently
from
9321764 to
a0a1060
Compare
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
from
a0a1060 to
e78ea8a
Compare
|
cc me when ready for review. |
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
4 times, most recently
from
e17c3b3 to
3d47f62
Compare
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
2 times, most recently
from
9dd83ed to
25ad37d
Compare
|
I've changed a lot, can you have a look, thanks. @RainbowMango |
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
3 times, most recently
from
d3fc4a4 to
ae29c06
Compare
RainbowMango
requested changes
May 26, 2021
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
2 times, most recently
from
2ba2a61 to
50fc9af
Compare
Signed-off-by: changzhen <changzhen5@huawei.com>
Signed-off-by: changzhen <changzhen5@huawei.com>
XiShanYongYe-Chang
force-pushed
the
imageoverride
branch
from
50fc9af to
c06c046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
ImageOverrider implementation
Which issue(s) this PR fixes:
Fixes #313
Special notes for your reviewer:
Does this PR introduce a user-facing change?: