Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support schedule based on cluster provider/region/zone #357

Merged
merged 2 commits into from
May 25, 2021

Conversation

mrlihanbo
Copy link

Signed-off-by: lihanbo lihanbo2@huawei.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
support schedule based on cluster provider/region/zone

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
"NONE"

pkg/webhook/clusterpropagationpolicy/validating.go Outdated Show resolved Hide resolved
pkg/webhook/propagationpolicy/validating.go Outdated Show resolved Hide resolved
pkg/util/selector.go Outdated Show resolved Hide resolved
pkg/util/selector.go Outdated Show resolved Hide resolved
@mrlihanbo mrlihanbo force-pushed the fieldSelector branch 2 times, most recently from 74c05a5 to 5e247c2 Compare May 21, 2021 02:10
@mrlihanbo
Copy link
Author

@carmark Thanks for your review. I have added e2e test, PTAL, Thanks

@RainbowMango RainbowMango self-assigned this May 22, 2021
pkg/webhook/propagationpolicy/validating.go Outdated Show resolved Hide resolved
pkg/util/helper/policy.go Outdated Show resolved Hide resolved
pkg/util/helper/policy.go Outdated Show resolved Hide resolved
test/e2e/fieldselector_test.go Outdated Show resolved Hide resolved
test/e2e/fieldselector_test.go Show resolved Hide resolved
mrlihanbo added 2 commits May 24, 2021 15:04
Signed-off-by: lihanbo <lihanbo2@huawei.com>
Signed-off-by: lihanbo <lihanbo2@huawei.com>
@RainbowMango
Copy link
Member

@carmark Do you have any other comments?

@carmark
Copy link
Member

carmark commented May 24, 2021

@RainbowMango No others, thanks.

@RainbowMango RainbowMango merged commit 7e1e7b9 into karmada-io:master May 25, 2021
@mrlihanbo mrlihanbo deleted the fieldSelector branch November 23, 2021 12:18
jwcesign pushed a commit to jwcesign/karmada that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants