-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:search http response add content-type header #3505
Conversation
Hi @callmeoldpince, thanks for your feedback. Can you explain why it's set up to |
I tried with kube-apiserver, the header is I think the benefit is: make some json parse tools work fine. cc @callmeoldpince Do I understand correctly? |
@jwcesign @XiShanYongYe-Chang |
@callmeoldpince I think this is not a bug. |
Both are OK with me. @callmeoldpince are you using Karmada in production? Do you need this patch on release branches? |
1 similar comment
Both are OK with me. @callmeoldpince are you using Karmada in production? Do you need this patch on release branches? |
yes,I hope it can be merged into release1.5 |
Signed-off-by: old.prince <di7zhang@gmail.com>
/lgtm Hi @callmeoldpince Can you help cherry-pick this PR to branch release-1.5/release-1.4? |
Sorry, I didn't describe it clearly. Can you change it to something like this?
|
I hope it can be merged into release1.5 |
done |
We can sync it to all the versions we've affected before. |
Ask @RainbowMango to help run the ci test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks~
Hi @callmeoldpince excuse me, would it be convenient to reveal the name of your company?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @callmeoldpince, thanks a lot. This patch have been merged, would you like to help cherry-pick it to the previous branch: release-1.3, release-1.4, release-1.5. You can cherry-pick refer to: https://karmada.io/docs/next/contributor/cherry-picks/ |
@XiShanYongYe-Chang I refer to the document to operate |
Thanks~, please help update the release note in the new pr. |
ok,done |
…-#3505-upstream-release-1.4 Automated cherry pick of #3505: fix:search http response add content-type header
Thanks @callmeoldpince and welcome to Karmada community~ |
…-#3505-upstream-release-1.3 Automated cherry pick of #3505: fix:search http response add content-type header
…f-#3505-upstream-release-1.5 Automated cherry pick of #3505: fix:search http response add content-type header
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adding HTTP response headers for k8s native clients to decode normally
Which issue(s) this PR fixes:
Fixes:Search service request returns text/plain by default
Special notes for your reviewer:
Does this PR introduce a user-facing change?: