Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #2928: Fix misjudgment of deployment and statefuleset health status #2944

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Automated cherry pick of #2928: Fix misjudgment of deployment and statefuleset health status #2944

merged 1 commit into from
Dec 12, 2022

Conversation

Fish-pro
Copy link
Member

@Fish-pro Fish-pro commented Dec 12, 2022 •
edited by RainbowMango
Loading

Cherry pick of #2928 on release-1.4.
#2928: Fix Deployment and Statefulset health judgments
For details on the cherry pick process, see the cherry pick requests page.

`karmada-controller-manager`/`karmada-agent`: Fixed misjudgment of deployment and statefuleset health status.

@Fish-pro
Fix Deployment and Statefulset health judgments
8a4f5c7 
Signed-off-by: chen zechun <zechun.chen@daocloud.io>
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2022
@Fish-pro Fish-pro changed the title Automated cherry pick of #2928: Fix Deployment and Statefulset health judgments Automated cherry pick of #2928: Fix misjudgment of deployment and statefuleset health status Dec 12, 2022
@XiShanYongYe-Chang
Copy link
Member

/release-note-edit karmada-controller-manager\karmada-agent: Fix misjudgment of deployment and statefuleset health status

Hi @Fish-pro, I update the release note.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@karmada-bot karmada-bot merged commit 9ecdeb8 into karmada-io:release-1.4 Dec 12, 2022
@Fish-pro
Copy link
Member Author

/release-note-edit karmada-controller-manager\karmada-agent: Fix misjudgment of deployment and statefuleset health status

Hi @Fish-pro, I update the release note.

@XiShanYongYe-Chang Thanks.

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang Thanks.

Looks like I didn't make the change.

@Fish-pro Fish-pro deleted the automated-cherry-pick-of-#2928-upstream-release-1.4 branch March 18, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@ikaven1024 ikaven1024 Awaiting requested review from ikaven1024

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fish-pro @XiShanYongYe-Chang @karmada-bot