Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #2915 to release-1.3: fix that validating for resourceinterpreterwebhookconfigurations #2923

Conversation

qingwave
Copy link
Contributor

@qingwave qingwave commented Dec 8, 2022

… not work

Signed-off-by: hejunhua hejunhua@cestc.cn

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #2921

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed the default ValidatingWebhookConfiguration for `resourceinterpreterwebhook` not working issue.

… not work

Signed-off-by: hejunhua <hejunhua@cestc.cn>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 8, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2022
@qingwave
Copy link
Contributor Author

qingwave commented Dec 8, 2022

/assign @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@karmada-bot karmada-bot merged commit 2cc4b47 into karmada-io:release-1.3 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants