Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolute CustomizedClusterResourceModeling to Beta and enable it by default #2877

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented Nov 28, 2022

Signed-off-by: Poor12 shentiecheng@huawei.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:

The CustomizedClusterResourceModeling feautre hes been stably supported since version v1.3. It is planned to enable the CustomizedClusterResourceModeling FeatureGate by default and evolute it to beta.

The detailed usage can be found in https://karmada.io/docs/next/userguide/scheduling/cluster-resources.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager, karmada-aggregated-apiserver, karmada-scheduler: evolute CustomizedClusterResourceModeling FeatureGate to Beta  and enable it by default

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 28, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #2877 (a8dae55) into master (b43e3ea) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2877      +/-   ##
==========================================
- Coverage   38.17%   38.15%   -0.02%     
==========================================
  Files         197      197              
  Lines       18101    18101              
==========================================
- Hits         6910     6907       -3     
- Misses      10787    10790       +3     
  Partials      404      404              
Flag Coverage Δ
unittests 38.15% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/search/proxy/store/util.go 91.94% <0.00%> (-1.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RainbowMango
Copy link
Member

Please solve the conflicts.

…ble it by default

Signed-off-by: Poor12 <shentiecheng@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@karmada-bot karmada-bot merged commit 32291df into karmada-io:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants