Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmadactl token:print correct register command according to the karm… #2707

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

Songjoy
Copy link
Contributor

@Songjoy Songjoy commented Oct 31, 2022

…ada-context flag

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix karmadactl token:print correct register command according to the karmada-context flag

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`: Fixed `init` commands print incorrect register command issue. 

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2022
@carlory
Copy link
Member

carlory commented Oct 31, 2022

@RainbowMango Can you approve running workflows?

@RainbowMango
Copy link
Member

done.

@codecov-commenter
Copy link

Codecov Report

Merging #2707 (3ade938) into master (e6e946f) will increase coverage by 0.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2707      +/-   ##
==========================================
+ Coverage   29.12%   29.86%   +0.74%     
==========================================
  Files         190      190              
  Lines       19052    19046       -6     
==========================================
+ Hits         5548     5689     +141     
+ Misses      13151    13013     -138     
+ Partials      353      344       -9     
Flag Coverage Δ
unittests 29.86% <0.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/karmadactl/cmdinit/karmada/deploy.go 0.00% <0.00%> (ø)
pkg/karmadactl/register.go 0.00% <0.00%> (ø)
pkg/karmadactl/token.go 0.00% <0.00%> (ø)
pkg/search/proxy/store/util.go 94.15% <0.00%> (+0.58%) ⬆️
pkg/search/proxy/store/store.go 68.42% <0.00%> (+3.15%) ⬆️
pkg/util/worker.go 71.42% <0.00%> (+4.76%) ⬆️
pkg/util/cluster.go 94.79% <0.00%> (+55.57%) ⬆️
pkg/util/membercluster_client.go 69.56% <0.00%> (+69.56%) ⬆️
pkg/util/clusterlease.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lonelyCZ
Copy link
Member

lonelyCZ commented Nov 3, 2022

Thanks @Songjoy , I will look it ASAP.

/assign

@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 3, 2022
@lonelyCZ
Copy link
Member

lonelyCZ commented Nov 3, 2022

Hi, @Songjoy , you need to rebase your branch, and commit it again. Please refer https://karmada.io/docs/contributor/github-workflow#reverting-a-commit

…ada-context flag

Signed-off-by: 宋文杰 <wenjie.song@daocloud.io>
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 3, 2022
@Songjoy
Copy link
Contributor Author

Songjoy commented Nov 3, 2022

fixed @lonelyCZ

@lonelyCZ
Copy link
Member

lonelyCZ commented Nov 3, 2022

I just tested it that worked fine.

LGTM

Hi, @RainbowMango, please approve to run workflows.

@RainbowMango
Copy link
Member

done

@lonelyCZ
Copy link
Member

lonelyCZ commented Nov 3, 2022

/lgtm
/approve

I think we could cherry-pick this commit to v1.3 according to https://karmada.io/docs/contributor/cherry-picks, do you want to take over this work? @Songjoy

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@karmada-bot karmada-bot merged commit 24ae749 into karmada-io:master Nov 3, 2022
@Songjoy
Copy link
Contributor Author

Songjoy commented Nov 4, 2022

done @lonelyCZ

karmada-bot added a commit that referenced this pull request Nov 7, 2022
…upstream-release-1.3

Automated cherry pick of #2707 on release-1.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants