-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
karmadactl token:print correct register command according to the karm… #2707
Conversation
@RainbowMango Can you approve running workflows? |
done. |
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
==========================================
+ Coverage 29.12% 29.86% +0.74%
==========================================
Files 190 190
Lines 19052 19046 -6
==========================================
+ Hits 5548 5689 +141
+ Misses 13151 13013 -138
+ Partials 353 344 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks @Songjoy , I will look it ASAP. /assign |
Hi, @Songjoy , you need to rebase your branch, and commit it again. Please refer https://karmada.io/docs/contributor/github-workflow#reverting-a-commit |
…ada-context flag Signed-off-by: 宋文杰 <wenjie.song@daocloud.io>
fixed @lonelyCZ |
I just tested it that worked fine. LGTM Hi, @RainbowMango, please approve to run workflows. |
done |
/lgtm I think we could cherry-pick this commit to v1.3 according to https://karmada.io/docs/contributor/cherry-picks, do you want to take over this work? @Songjoy |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lonelyCZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
done @lonelyCZ |
…upstream-release-1.3 Automated cherry pick of #2707 on release-1.3.
…ada-context flag
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix karmadactl token:print correct register command according to the karmada-context flag
Special notes for your reviewer:
Does this PR introduce a user-facing change?: