-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add native resource metrics in proxy #2481
Conversation
Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
/assign @XiShanYongYe-Chang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, ask @Poor12 to take a look.
Hi @ikaven1024, can you help update the release note, thanks~ |
A little question, from the before and after changes in metrics, I found that metrics ignores the group "search.karmada.io", is this a consideration? |
This is actually the group name of request resource. In this example, the group of pods and nodes is just "".
|
Thanks for explaination. Generally look good to me. |
Thanks for @Poor12 . /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yingjinhui yingjinhui@didiglobal.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
When accessing resources via proxy, metrics only records
proxying
, can't see real resources:This PR will record the real resources:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: