Support for the cluster-api v1beta1 version #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
gy95
reviewed
Nov 25, 2021
Signed-off-by: Xinzhao Xu <z2d@jifangcheng.com>
Signed-off-by: Xinzhao Xu <z2d@jifangcheng.com>
iawia002
force-pushed
the
cluster-api-v1beta1
branch
from
f6d799f to
29f10db
Compare
|
@iawia002 Thanks, it looks great to me. |
|
/assign @RainbowMango |
|
/lgtm |
|
It works ok on my side. 👍 |
|
/approve cc @duguhaotian |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bump the
sigs.k8s.io/cluster-apipackage to v1.0.1 to support theClusterv1beta1 version. I have checked the v1beta1 version of theClusterobject, and the cluster phase and secret we need have no breaking changes, this patch should work fine.ref #594
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I directly used the constants of the
sigs.k8s.io/cluster-api/util/secretpackage from cluster-api repo instead of our own definition.Does this PR introduce a user-facing change?:
/cc @XiShanYongYe-Chang