Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support update object annotations #1012

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

mrlihanbo
Copy link

@mrlihanbo mrlihanbo commented Nov 23, 2021

Signed-off-by: lihanbo lihanbo2@huawei.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
For annotations set by controllers in a member cluster we won't overwrite them. But for annotations set by user in resource template, we should support to update them. Before this commit, annotations can't update if resource has been propagated which is unreasonable.

Which issue(s) this PR fixes:
Fixes #794 #650

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: fixed the annotation of resource template can not be updated issue.

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 23, 2021
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2021
@XiShanYongYe-Chang
Copy link
Member

This pr fix the issue #650

@pigletfly

Signed-off-by: lihanbo <lihanbo2@huawei.com>
@XiShanYongYe-Chang
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@karmada-bot karmada-bot merged commit 3b52b0d into karmada-io:master Nov 23, 2021
@mrlihanbo mrlihanbo deleted the update-annotation branch November 23, 2021 12:19
@RainbowMango
Copy link
Member

/kind remove cleanup
/kind bug

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 24, 2021
@karmada-bot
Copy link
Collaborator

@RainbowMango: The label(s) kind/remove cannot be applied, because the repository doesn't have them.

In response to this:

/kind remove cleanup
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RainbowMango
Copy link
Member

/remove-kind cleanup

@karmada-bot karmada-bot removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants