-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support update object annotations #1012
Conversation
This pr fix the issue #650 |
Signed-off-by: lihanbo <lihanbo2@huawei.com>
f03455e
to
df925c7
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind remove cleanup |
@RainbowMango: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-kind cleanup |
Signed-off-by: lihanbo lihanbo2@huawei.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
For annotations set by controllers in a member cluster we won't overwrite them. But for annotations set by user in resource template, we should support to update them. Before this commit, annotations can't update if resource has been propagated which is unreasonable.
Which issue(s) this PR fixes:
Fixes #794 #650
Special notes for your reviewer:
Does this PR introduce a user-facing change?: