Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karmadactl support list images #4086

Open
liangyuanpeng opened this issue Sep 26, 2023 · 6 comments
Open

karmadactl support list images #4086

liangyuanpeng opened this issue Sep 26, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@liangyuanpeng
Copy link
Contributor

What would you like to be added:

Support command of karmadactl config images list

Why is this needed:

@liangyuanpeng liangyuanpeng added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2023
@lonelyCZ
Copy link
Member

Hi @liangyuanpeng ,thanks for your contributions, could you share the usage scenario and why to do it?

@liangyuanpeng
Copy link
Contributor Author

Since the karmadactl init component is serial, I would like to first pull all required container images before deploying to speed up the init process.

@liangyuanpeng
Copy link
Contributor Author

$ kubeadm config images list
registry.k8s.io/kube-apiserver:v1.30.0
registry.k8s.io/kube-controller-manager:v1.30.0
registry.k8s.io/kube-scheduler:v1.30.0
registry.k8s.io/kube-proxy:v1.30.0
registry.k8s.io/coredns/coredns:v1.11.1
registry.k8s.io/pause:3.9
registry.k8s.io/etcd:3.5.12-0

@liangyuanpeng
Copy link
Contributor Author

$ kubeadm config images  list --image-repository=registry.k8s.io2
registry.k8s.io2/kube-apiserver:v1.30.0
registry.k8s.io2/kube-controller-manager:v1.30.0
registry.k8s.io2/kube-scheduler:v1.30.0
registry.k8s.io2/kube-proxy:v1.30.0
registry.k8s.io2/coredns:v1.11.1
registry.k8s.io2/pause:3.9
registry.k8s.io2/etcd:3.5.12-0

@tiansuo114
Copy link
Contributor

Hello tutor, I am currently developing the code of this function, and I have encountered some problems and would like to ask your opinion
I observed that in kubeadm,image list is constructed by constructing an InitConfiguration structure, in which all deployment information and image addresses are stored. However, karmada seems to assemble strings through many private methods of CommandInitOption to compose image address information required for deployment I am not sure how to get it. I hope you can give me some suggestions

@liangyuanpeng

@liangyuanpeng
Copy link
Contributor Author

we decide pause to work for feature of karmadactl image list based on the content of the meeting, #5387

This feature will be reconsidered if it is generally needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants