Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karma.js #923

Closed
wants to merge 6 commits into from
Closed

Update karma.js #923

wants to merge 6 commits into from

Conversation

MrP
Copy link
Contributor

@MrP MrP commented Feb 12, 2014

using Windows, the paths may look like this: aaaa\bbb\uuu
And Js gets confused because of the \u.

using Windows, the paths may look like this: aaaa\bbb\uuu
And Js gets confused because of the \u.
Line didn't pass linting because it was too long
I had a trailing whitespace
@vojtajina
Copy link
Contributor

Please add a unit test for it.
I think we should just escape any backslash (not only \u).

Also, make sure to follow karma-runner.github.io/0.10/dev/git-commit-msg.html and then squash everything into a single commit.

Thank you for help @MrP !

@MrP
Copy link
Contributor Author

MrP commented Feb 23, 2014

Thanks for the feedback! I was away on vacation, I'll get to it soon.

fix(runner): Karma hangs when file paths have \u in them #924

Escape backslashes in paths (which happen in Windows)
to prevent bad IDs (e.g. aaa\uuuu).

Closes #924
test(runner): Tests issue #924, backslashes in paths
@MrP
Copy link
Contributor Author

MrP commented Feb 24, 2014

Hi,
I created a new pull request #932 with the single commit. I didn't manage to rebase and squash the ones already here.

Is that the way it should be done? If not, could you point me to some guide on how to do it right?

Thanks,
Victor

@vojtajina
Copy link
Contributor

Thanks @MrP ! Merged the #932.

@vojtajina vojtajina closed this Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants