refactor(test): move execKarma into the World #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also generalize a step to accept any CLI arguments instead of only log-level. This should make this step more flexible. The removed step was not very clear as to which command it applies to (foreground or background) and is fully covered with expanded "I {command} Karma ..." step.
|
✅ Build karma 255 completed (commit d3a3e63924 by @devoto13) |
devoto13
commented
May 7, 2020
| @@ -42,6 +42,7 @@ class World { | |||
| frameworks: ['jasmine'], | |||
| basePath: this.workDir, | |||
| colors: false, | |||
| logLevel: 'warn', | |||
There was a problem hiding this comment.
This value was previously set in execKarma.
|
✅ Build karma 254 completed (commit d3a3e63924 by @devoto13) |
johnjbarton
approved these changes
May 7, 2020
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
Also generalize a step to accept any CLI arguments instead of only log-level. This should make this step more flexible. The removed step was not very clear as to which command it applies to (foreground or background) and is fully covered with expanded "I {command} Karma ..." step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generalize a step to accept any CLI arguments instead of only log-level. This should make this step more flexible. After the recent changes the removed step was not very clear as to which command (foreground or background) it applies to and is fully covered with expanded "I {command} Karma ..." step.