Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove more old connection security stuffs #3459

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

johnjbarton
Copy link
Contributor

No description provided.

@johnjbarton johnjbarton requested a review from kyliau April 8, 2020 15:26
@AppVeyorBot
Copy link

Build karma 2559 completed (commit 0ff176f937 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 161 completed (commit 0ff176f937 by @johnjbarton)

@karmarunnerbot
Copy link
Member

Build karma 160 completed (commit 0ff176f937 by @johnjbarton)

@johnjbarton johnjbarton merged commit 4d45cf0 into karma-runner:master Apr 8, 2020
@devoto13
Copy link
Collaborator

devoto13 commented Apr 8, 2020

@johnjbarton Nice! Let's see if this solves SauceLabs error on master.

@devoto13
Copy link
Collaborator

devoto13 commented Apr 8, 2020

@johnjbarton I had a PR to update the check in integration-tests repo: https://github.com/karma-runner/integration-tests/pull/11/files. But I think now it is better to use something similar to what you do in https://github.com/karma-runner/karma/pull/3461/files. Will update the PR soon.

@devoto13
Copy link
Collaborator

devoto13 commented Apr 8, 2020

@johnjbarton After some digging it seems that the problem is this line. My theory is that https://github.com/karma-runner/integration-tests/tree/master/saucelabs test tries to start Sauce Connect proxy, but fails because it is already started by Travis itself. Can't check it though, because SAUCE_* variables are only available to the master branch and I can't access them in my debugging branch.

@johnjbarton
Copy link
Contributor Author

I think the integration-tests are installed in the karma-runner/karma travis session so I don't think that .travis.yml is read. But your theory about the sauce connect could still be right, I just added that line as a guess. I "unguessed" and I updated the integration_tests travis file also, thanks.

@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants