-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): remove more old connection security stuffs #3459
Conversation
✅ Build karma 2559 completed (commit 0ff176f937 by @johnjbarton) |
✅ Build karma 161 completed (commit 0ff176f937 by @johnjbarton) |
✅ Build karma 160 completed (commit 0ff176f937 by @johnjbarton) |
@johnjbarton Nice! Let's see if this solves SauceLabs error on master. |
@johnjbarton I had a PR to update the check in integration-tests repo: https://github.com/karma-runner/integration-tests/pull/11/files. But I think now it is better to use something similar to what you do in https://github.com/karma-runner/karma/pull/3461/files. Will update the PR soon. |
@johnjbarton After some digging it seems that the problem is this line. My theory is that https://github.com/karma-runner/integration-tests/tree/master/saucelabs test tries to start Sauce Connect proxy, but fails because it is already started by Travis itself. Can't check it though, because SAUCE_* variables are only available to the |
I think the integration-tests are installed in the |
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.