Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inject yargs and minimist instead of optimist #3449

Closed
wants to merge 2 commits into from
Closed

refactor: inject yargs and minimist instead of optimist #3449

wants to merge 2 commits into from

Conversation

akkumar
Copy link

@akkumar akkumar commented Mar 20, 2020

Trying to remove optimist and replace to yargs.

Code - untested.

Would be useful to get somebody review changes to cli.js and cli.spec.js specifically.

Related issues #2472 and #2473 and #3447

@AppVeyorBot
Copy link

Build karma 2530 failed (commit 5d347eb540 by @akkumar)

@karmarunnerbot
Copy link
Member

Build karma 132 failed (commit 5d347eb540 by @akkumar)

@karmarunnerbot
Copy link
Member

Build karma 131 completed (commit 5d347eb540 by @akkumar)

@Den-dp
Copy link

Den-dp commented Mar 24, 2020

Any ideas is that a random CI failure or no?
https://travis-ci.org/github/karma-runner/karma/jobs/664832744#L877

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@akkumar can you confirm that it's passes locally?

@philmayfield
Copy link

This appears to have already been merged in #3451

@johnjbarton
Copy link
Contributor

Thanks, looks like this was completed.

@johnjbarton johnjbarton closed this Apr 1, 2020
@akkumar akkumar deleted the remove_optimist branch April 2, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants