Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use native Promise instead of Bluebird #3436

Merged
merged 1 commit into from
Mar 18, 2020
Merged

refactor: use native Promise instead of Bluebird #3436

merged 1 commit into from
Mar 18, 2020

Commits on Feb 28, 2020

  1. refactor: use native Promise instead of Bluebird 

    All supported Node versions support native promises and async/await, current code has a minimal usage of Bluebird-specific methods, so dropping a third-party library in favor of native Promises.

Tests were using `Promise.setScheduler()` from Bluebird, which allowed to customize how Promises are scheduled and made test work very different from the real code, which created tricky issues (like karma-runner#3060 (comment)). Affected tests were updated to not rely on `Promise.setScheduler()`, which improved readability in some situations. Also removed some test helpers as they are not necessary and not used anymore.

BREAKING CHANGE: Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
    @devoto13
    devoto13 committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    b2d9ba3 View commit details
    Browse the repository at this point in the history