-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update lib/reporter/multi.js to ES6 #3018
refactor: update lib/reporter/multi.js to ES6 #3018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what this code does? what happens if we add or remove an "adapter" from a reporter?
MultiReporter instance is returned from createReporters method: Line 155 in ac4e1a9
so MultiReporter seems to be container that group a few reporters. According to this implementation: Lines 48 to 59 in 35965d9
adapter is function invoked with message inside |
@lusarz is right. |
Thanks! The change is simple enough but we don't have any tests and I did not see the code that uses this. |
No description provided.