Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-web-security flag to Chrome launcher. #288

Closed
wants to merge 1 commit into from
Closed

Add --disable-web-security flag to Chrome launcher. #288

wants to merge 1 commit into from

Conversation

DavidSouther
Copy link
Contributor

Adding the disable-web-security flag to Chrome (and likely safari) no longer forces the tests to run through a proxy, eliminating the headaches seen in #86, #90, #179, and others. When using ANGULAR_SCENARIO, tests can now do things like

browser().navigateTo("http://www.nytimes.com/")
expect(element('.story').count()).toBeGreaterThan 0

The entire suite becomes, in a stroke, much more powerful and easy to use than Selenium.

Major drawbacks: I haven't been able to find similar flags for Firefox or IE.

@dignifiedquire
Copy link
Member

While I think it's great to have this option I would vote to not include it by default but rather use somethink like in #278.

@vojtajina
Copy link
Contributor

Agree with @dignifiedquire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants