Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RequireJS documentation typo #1651

Merged
merged 1 commit into from
Oct 23, 2015

Conversation

skycocker
Copy link
Contributor

"We do this is test/test-main.js."
"We do this in test/test-main.js."

@GitCop
Copy link

GitCop commented Oct 22, 2015

There were the following issues with your Pull Request

  • Commit: 8877d51
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@zzo
Copy link
Contributor

zzo commented Oct 22, 2015

looks good please follow commit message convention

@GitCop
Copy link

GitCop commented Oct 23, 2015

There were the following issues with your Pull Request

  • Commit: 5cbb96f
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@skycocker
Copy link
Contributor Author

@googlebot Signed.
@zzo, @GitCop Commit message updated.

@googlebot
Copy link

CLAs look good, thanks!

dignifiedquire added a commit that referenced this pull request Oct 23, 2015
Fix RequireJS documentation typo
@dignifiedquire dignifiedquire merged commit ef6f05c into karma-runner:master Oct 23, 2015
@dignifiedquire
Copy link
Member

Thanks :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants