Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): exit process when browser is not captured in captureTimeout... #1150

Closed
wants to merge 1 commit into from

Conversation

binyroo
Copy link

@binyroo binyroo commented Aug 4, 2014

exit process when browser is not captured in captureTimeout

@j0tunn
Copy link
Contributor

j0tunn commented Aug 5, 2014

Your solution breaks retry functionality. Take a look at #1151
The problem with timeout in most cases is the launcher issue. Here is for example fix for karma-webdriver-launcher: karma-runner/karma-webdriver-launcher#14

@binyroo
Copy link
Author

binyroo commented Aug 6, 2014

thank you for advice

@vojtajina
Copy link
Contributor

@binyroo I'm not sure I understand the issue. Can you describe more? What is the problem you are solving?

@dignifiedquire
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants