-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The backslash character is not escaped when using html2js (angular) #583
Comments
@lgalfaso would you mind sending a pull request to https://github.com/karma-runner/karma-ng-html2js-preprocessor That would be awesome. If you include a test case for this, that would be even more awesome, you would certainly become super famous and all girls would want you, etc... |
Done. |
Is this still an active issue or is it dead because its fixed in the newer release? |
If there are plans for a 0.8.7 release, I can create a PR for it. @vojtajina ? |
@lgalfaso thanks, I saw your PR and commented. I hope to get the canary into stable release soon, I think I'm only missing updating the docs. But it's still gonna be faster to push another patch release of 0.8._, so _if you wanna send a PR for the 0.8.* (current stable) branch as well that's great*. (btw. add |
Fix the test that escapes the backslash Closes karma-runner#583
At the html2js preprocessor escape the backslash character when this is present in a template Closes karma-runner#583
At the html2js preprocessor escape the backslash character when this is present in a template Closes karma-runner#583
I believe this has been fixed by #612 |
The backslash character "" is not escaped when using the html2js preprocessor for angular
The change is very simple, just changing lib/preprocessors/Html2js.js from
to
I was not able to make the project karma-ng-html2js-preprocessor so posting the issue here so it gets some visibility
The text was updated successfully, but these errors were encountered: