Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Android Browser recognized as Safari 4 #318

Closed
IgorMinar opened this issue Jan 22, 2013 · 2 comments
Closed

Legacy Android Browser recognized as Safari 4 #318

IgorMinar opened this issue Jan 22, 2013 · 2 comments

Comments

@IgorMinar
Copy link
Contributor

When I connect to Testacular with the old Android Browser, Testacular labels it as Safari 4. It should be called Android Browser 4.2.

I looked if the browser has some public versioning scheme but it doesn't seem to be the case, so calling it Android Browser <AndroidVersion> should be the right thing to do.

Sample user agent string:

Mozilla/5.0 (Linux; U; Android 4.2; en-us; sdk Build/JB_MR1) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30
dignifiedquire added a commit to dignifiedquire/karma that referenced this issue Apr 20, 2013
By using the module 3rd-Eden/useragent instead of a homegrown solution
we are able to parse a much wider range of useragent strings.
Fixes karma-runner#373, karma-runner#318.
dignifiedquire added a commit to dignifiedquire/karma that referenced this issue Apr 20, 2013
By using the module 3rd-Eden/useragent instead of a homegrown solution
we are able to parse a much wider range of useragent strings.
Fixes karma-runner#373, karma-runner#318.
@vojtajina
Copy link
Contributor

@dignifiedquire Is this fixed by using useragent module ? I though that already got merged. If so, please close this.

@dignifiedquire
Copy link
Member

Yes it should be. Must have forgotten to add it in the commit message. There is even a test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants