-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy Android Browser recognized as Safari 4 #318
Comments
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this issue
Apr 20, 2013
By using the module 3rd-Eden/useragent instead of a homegrown solution we are able to parse a much wider range of useragent strings. Fixes karma-runner#373, karma-runner#318.
dignifiedquire
added a commit
to dignifiedquire/karma
that referenced
this issue
Apr 20, 2013
By using the module 3rd-Eden/useragent instead of a homegrown solution we are able to parse a much wider range of useragent strings. Fixes karma-runner#373, karma-runner#318.
@dignifiedquire Is this fixed by using |
Yes it should be. Must have forgotten to add it in the commit message. There is even a test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I connect to Testacular with the old Android Browser, Testacular labels it as Safari 4. It should be called Android Browser 4.2.
I looked if the browser has some public versioning scheme but it doesn't seem to be the case, so calling it
Android Browser <AndroidVersion>
should be the right thing to do.Sample user agent string:
The text was updated successfully, but these errors were encountered: