Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usePolling should be false for newer macOS? #2669

Closed
michaelsbradleyjr opened this issue Apr 20, 2017 · 2 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122, Omrisnyk/npm-lockfiles#132 or satoshinakamoto007/bitcore#1135

Comments

@michaelsbradleyjr
Copy link

michaelsbradleyjr commented Apr 20, 2017

See: https://github.com/karma-runner/karma/blob/master/lib/config.js#L318

tracking it back w/ blame:

66f50d7

66f50d7#commitcomment-21831412

On current macOS (I'm running 10.12.4, for example) setting usePolling to false works much better than having it set true, and the CPU utilization is dramatically lower. I'm running node v7.9.0, latest releases of karma, etc.

@wesleycho
Copy link
Member

Thoughts on this @dignifiedquire? Sounds like it might be reasonable to change this and releasing a hotfix if it becomes an issue again.

@dignifiedquire
Copy link
Member

I haven't tested it myself, but I am okay changing the default with 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment