Skip to content

Commit

Permalink
Show error from browser, even if the exit code is zero
Browse files Browse the repository at this point in the history
Closes #71
  • Loading branch information
vojtajina committed Jan 13, 2013
1 parent bb3da0a commit 825a61d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/launchers/Base.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ var BaseBrowser = function(id, emitter, captureTimeout, retryLimit) {
this._onProcessExit = function(code, errorOutput) {
log.debug('Process %s exitted with code %d', self.name, code);

if (code) {
if (code || errorOutput) {
log.error('Cannot start %s\n\t%s', self.name, errorOutput);
}

Expand Down

2 comments on commit 825a61d

@dignifiedquire
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is ideal. On my system I get now on every run:

error (launcher): Cannot start Chrome
    [66832:-1401732416:0113/200431:ERROR:master_preferences.cc(104)] Failed to read master_preferences file at /Library/Google/Google Chrome Master Preferences. Falling back to default preferences.

But everything is running fine :/

@vojtajina
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I didn't feel well when I was doing it. Reverted by vojtajina/testacular@75b6f88

Please sign in to comment.