Cannot turn screenshot recording off

[jhchen]

If we set recordScreenshot to false this line https://github.com/karma-runner/karma-sauce-launcher/blob/master/lib/sauce_launcher.js#L72

'record-screenshots': args.recordScreenshots || config.recordScreenshots || true

still evaluates to true. I'm not sure why but passing in

sauceLabs: {
  options: {
    'record-screenshots': false
  }
}

is not a valid workaround so perhaps helper.merge has a similar issue.

[ChrisWren]

The logic is wrong. I have a local branch fixing this which I haven't tested yet but will push by end of day today. Sorry about this.

[jhchen]

No worries thanks for the quick response!