Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in debug mode when using socket io #11

Closed
pablojim opened this issue Dec 2, 2013 · 2 comments · Fixed by #13
Closed

Error in debug mode when using socket io #11

pablojim opened this issue Dec 2, 2013 · 2 comments · Fixed by #13

Comments

@pablojim
Copy link
Contributor

pablojim commented Dec 2, 2013

I have some tests that uses socket.io. The debug view fails in this scenario

Uncaught TypeError: Cannot read property 'transport' of undefined from line https://github.com/karma-runner/karma-jasmine/blob/master/src/adapter.js#L42

This is related to #5.
@pablojim pablojim mentioned this issue Dec 2, 2013
Closed
@vojtajina
Copy link
Contributor

@pablojim How come that it goes through the if (!window.parent.io) in your case? https://github.com/karma-runner/karma-jasmine/blob/master/src/adapter.js#L37

@vojtajina
Copy link
Contributor

Nevermind, I got it;-)

pablojim added a commit to pablojim/karma-jasmine that referenced this issue Dec 5, 2013
@pablojim
fix: add a check for debug view with socket.io
72e8695 
Closes karma-runner#11
@pablojim pablojim mentioned this issue Dec 5, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add a check for debug view with socket.io pablojim/karma-jasmine
2 participants
@vojtajina @pablojim