Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silent option for gatling karate builder #2440

Conversation

ciandt-crodrigues
Copy link
Contributor

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

In my scenario, I would like to do a warm-up phase before my real performance test. I'd like to be able to reach all tested flows in order for the server to compile the code beforehand and not affect my response time (useful for .NET and JAVA servers).
For that, I implemented a feature like the .silent on the Gatling HTTP and HTTPProtocol.

I've added a unit test with the warm-up flow for one existing simulation

  • Relevant Issues : (compulsory)
  • Relevant PRs : (optional)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@ptrthomas
Copy link
Member

I'm not that familiar with this side of gatling. may I request @f-delahaye to do a review if possible. otherwise this LGTM

@ptrthomas ptrthomas merged commit e74145b into karatelabs:develop Nov 9, 2023
1 check passed
@f-delahaye
Copy link
Contributor

Sorry, @ptrthomas , missed your previous comment.

Does this need to be backported in the Java wrapper?

@ptrthomas
Copy link
Member

@f-delahaye I will let you take a call on it. it sounds like good to have, but I also think this is not that commonly used

@f-delahaye f-delahaye mentioned this pull request Dec 17, 2023
5 tasks
ptrthomas added a commit that referenced this pull request Jan 18, 2024
@ptrthomas
Copy link
Member

@ciandt-crodrigues I noticed an error in the build which was not failing the build, can you check if this looks ok: 6d80da8

@ciandt-crodrigues
Copy link
Contributor Author

ciandt-crodrigues commented Jan 18, 2024

@ciandt-crodrigues I noticed an error in the build which was not failing the build, can you check if this looks ok: 6d80da8

Sure, I'm busy in the next couple of days, do you have a deadline to go to next release? @ptrthomas

@ptrthomas
Copy link
Member

@ciandt-crodrigues no worries - this does not block the release, so take your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants