Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for self signed cert generation #2315

Merged
merged 1 commit into from
May 15, 2023

Conversation

kang-mansher
Copy link
Contributor

@kang-mansher kang-mansher commented May 15, 2023

Description

Added new SelfSignedCertGenerator to generate a self-signed certificate using SUN security provider in JVM
Bouncycastle provider(which was causing Runtime error - Noclassdeffound) was fetched from linecorp armeria library, which also has some dependencies in other parts. So I could not exclude transient dependency from the armeria.

Find attached the screenshot of the error in the existing fat jar and a successful server startup after the fix.

Error:
Screen Shot 2023-05-15 at 11 12 27 am

After Fix:
Screen Shot 2023-05-15 at 11 12 56 am

@ptrthomas ptrthomas merged commit 2a1023c into karatelabs:develop May 15, 2023
@staffier
Copy link

Sorry for the delay -- looks great!

% java -jar karate-1.5.0-SNAPSHOT.jar -m ~/karate/karate-core/src/test/java/com/intuit/karate/fatjar/server.feature -s
17:24:37.922 [main] INFO com.intuit.karate - Karate version: 1.5.0-SNAPSHOT
17:24:38.287 [main] WARN c.i.karate.http.SslContextFactory - ssl - cert.pem and / or key.pem not found, will create
17:24:39.500 [main] INFO com.intuit.karate - mock server initialized: ../src/test/java/com/intuit/karate/fatjar/server.feature
17:24:40.441 [main] DEBUG com.intuit.karate.http.HttpServer - server started: ml40j6md6r:8080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants