Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for the interactable lyric. #2273

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Aug 17, 2024

image

Each layer is testable.
Also, give interactable lyric layer loader to let it create the layer inside, for prevent construct the layer with lyric outside(code quality and safety reason).

@andy840119 andy840119 added code quality Improve code quality. test Test needed/included labels Aug 17, 2024
@andy840119 andy840119 added this to the 2024.0831 milestone Aug 17, 2024
@andy840119 andy840119 merged commit 5a1657c into karaoke-dev:master Aug 17, 2024
3 of 4 checks passed
@andy840119 andy840119 deleted the add-test-case-for-the-interactable-lyric branch August 17, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve code quality. size/L test Test needed/included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant