New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the EditableLyric in the lyric editor. #2261

Merged

andy840119 merged 8 commits into karaoke-dev:master from andy840119:refactor-the-editable-lyric-in-lyric-editor

Jul 13, 2024

Member

andy840119 commented Jul 13, 2024

Refactor part of #2258 before adjustment.

andy840119 added 7 commits

July 13, 2024 20:24


          Rename the caret type to state because it's much more make sense.

fd16494


          Rename the property in the enum.

ce3c06a


          Rename from BaseLayer to Layer.

2411ea1


          Move interact logic into individual layer.

1b4ec4c

Will only have InteractableLyric and lots of layer eventually.


          Make layer able to assign outside.

e532d46


          Move the lyric state to base class.

575634a


          Remove the class that inherit the InteractableLyric.

5dccf56

For now, the lyris folder should only contains InteractableLyric and lots of customized layer.

andy840119 added code quality LyricMaker labels

andy840119 added this to the 2024.0831 milestone

pull-request-size bot added the size/L label


          Make it as individual class to make the codefactor happy.

3a3f620

andy840119 merged commit 25a3e3d into karaoke-dev:master

4 checks passed

andy840119 deleted the refactor-the-editable-lyric-in-lyric-editor branch

July 13, 2024 14:50

andy840119 mentioned this pull request

Move PreviewKaraokeSpriteText into the child of LyricLayer. #2271

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality LyricMaker size/L