Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .editorconfig file #335

Closed
wants to merge 1 commit into from
Closed

Adding .editorconfig file #335

wants to merge 1 commit into from

Conversation

sonechca
Copy link

I added a new file ".editorconfig" for issue 302.
I focused on Java files and if I need to fix or add more, let me know by commenting here
This is my first time creating a .editorconfig file. But I want to finish this issue by myself
So you can give me any advice or tips as well, Thank you so much
Have a good Thanksgiving day

@sclassen
Copy link
Member

Wow this was super fast.
Please give us some time with this to review. My experience is that code formatting almost always leads to larger discussions.
So far we have not tried to decide on a common style for this project. Your PR will spark this discussion now.

Thank you for your contribution and sorry if this will take some time to get reviewed.

@sclassen sclassen linked an issue Oct 11, 2020 that may be closed by this pull request
10 tasks
@sclassen
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @sonechca on file. In order for us to review and merge your code, please visit https://dev.karakun.com/cla and follow the instructions on that page.

@cla-bot
Copy link

cla-bot bot commented Oct 15, 2020

The cla-bot has been summoned, and re-checked this pull request!

@hendrikebbers
Copy link
Contributor

@sonechca can you please sign our CLA? Otherwise we can not merge this PR :(

@sclassen
Copy link
Member

@sonechca Can you please sign the CLA so we can get this in as part of the Hacktober

@sclassen sclassen closed this Oct 30, 2020
@sclassen
Copy link
Member

fixed with #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding . editorconfig file
3 participants