fix: also removed reshape argument for prediction

when using lightgbm 4.0.0 - this is again a temproary fix
kapsner · Jul 18, 2023 · 09cde9d · 09cde9d
1 parent 47aeca9
commit 09cde9d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -40,7 +40,7 @@ VignetteBuilder:
     knitr
 Config/testthat/edition: 3
 Config/testthat/parallel: false
-Date/Publication: 2023-07-17 19:29:21.876818 UTC
+Date/Publication: 2023-07-18 05:09:17.26658 UTC
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.2.3
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,6 @@
 # mllrnrs NEWS
 
-## Unreleased (2023-07-17)
+## v0.0.2 (2023-07-17)
 
 #### Bug fixes
 
@@ -38,6 +38,8 @@
 
 #### Other changes
 
+-   updated news.md and description
+    ([47aeca9](https://github.com/kapsner/mllrnrs/tree/47aeca9df9197de14eb8c4b7a37a7579e3f55b33))
 -   updated cran-comments
     ([9be58ff](https://github.com/kapsner/mllrnrs/tree/9be58ffe0b30afa956dc8ad9732e2a7fdac65ab5))
 -   updated news.md
@@ -62,7 +64,7 @@
     ([af08974](https://github.com/kapsner/mllrnrs/tree/af0897471d09d71b29a10218030ad573a1b303c0))
 
 Full set of changes:
-[`v0.0.1...7a9ef30`](https://github.com/kapsner/mllrnrs/compare/v0.0.1...7a9ef30)
+[`v0.0.1...v0.0.2`](https://github.com/kapsner/mllrnrs/compare/v0.0.1...v0.0.2)
 
 ## v0.0.1 (2022-11-13)
 

diff --git a/R/learner_lightgbm.R b/R/learner_lightgbm.R
@@ -296,6 +296,8 @@ lightgbm_predict <- function(model, newdata, ncores, ...) {
     args$data <- newdata
   } else {
     args$newdata <- newdata
+    # remove also reshape argument (https://github.com/microsoft/LightGBM/pull/4971)
+    args$reshape <- NULL
   }
 
   preds <- do.call(stats::predict, args)