HELLODATA-1295 - starting portal may result 409 fix #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramich
reviewed
Mar 13, 2024
...i/src/main/java/ch/bedag/dap/hellodata/portal/initialize/service/DefaultUserInitializer.java
Outdated
Show resolved
Hide resolved
| // Check if the default user exists in Keycloak | ||
| boolean userExistsInKeycloak = getAllUsersFromKeycloak().stream().anyMatch(user -> user.getEmail().equals(defaultAdminProperties.getEmail())); | ||
| boolean userExistsInKeycloak = allUsersFromKeycloak.stream().anyMatch(user -> user.getEmail().equals(email)); |
There was a problem hiding this comment.
Couldn't you use here userByEmail.exists() (or if not, adjust to equalsIgnoreCase, like above)?
|
|
||
| //different email but duplicated username | ||
| if (!userByUsername.get().getEmail().equalsIgnoreCase(email)) { | ||
| defaultUsersInitiated = createDefaultAdmin(userByUsername.get().getUsername(), defaultAdminProperties.getFirstName(), defaultAdminProperties.getLastName(), |
There was a problem hiding this comment.
Doesn't this create an exception upon calling createUserInKeycloak() as this user already exists in KC?
There was a problem hiding this comment.
yes i does and it's good, now we'll have more logs to see where the problem is (most likely bad config)
ramich
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.