Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW29664234 maintenance updates #56

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dsanti82
Copy link
Collaborator

Description

Teamwork Ticket(s): Monthly Kanopi Pack Maintenance: update packages, including dependabots.

As a developer, I need to install security updates on a regular basis.

Acceptance Criteria

  • Existing Development and Production modes work
  • Watch mode successfully loads, like Production mode

Steps to Validate

  1. Use the feature branch to update your projects dependencies, add it npm i https://github.com/kanopi/kanopi-pack.git#feature/tw29664234/november-24-maintenance
  2. Run the Development command: npm run development, verify it builds the bundle and continues to listen without crashing.
  3. Load a page on the site using the assets
  4. Change an asset file, CSS, JS, etc and verify the command line shows the bundle rebuild (it will take about the same time production takes to build)
  5. Refresh the page and verify the changes show
  6. Run npm run production and load the site in Production mode. Verify site works as expected.

Notes

In order to run this update, you must use a forked version of https://github.com/ztoben/assets-webpack-plugin/ to address the typo on line 84 in the file lib/output/createOutputWriter.js.

@dsanti82 dsanti82 requested a review from sofiakanopi November 26, 2024 15:50
@sofiakanopi
Copy link
Contributor

@dsanti82 dsanti82 merged commit 35363b5 into main Nov 27, 2024
@dsanti82 dsanti82 deleted the feature/tw29664234/november-24-maintenance branch November 27, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants