Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch Mode #51

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Watch Mode #51

merged 5 commits into from
Mar 25, 2024

Conversation

rleeson
Copy link
Contributor

@rleeson rleeson commented Mar 22, 2024

Description

As a developer, I need to add a Watch mode to Kanopi Pack to support systems without the ability to use the Development Server, easily or at all.

  • Add a watch mode to standard command set, uses the watch polling options for Polling mode

Acceptance Criteria

  • Existing Development and Production modes work
  • Watch mode successfully loads, like Production mode

Steps to Validate

  1. Use the feature branch to update your projects dependencies, add it npm i https://github.com/kanopi/kanopi-pack.git#feature/watch
  2. Add a scripts key in your projects package.json to reference the watch command, i.e.: "watch": "kanopi-pack standard watch"
  3. Run the watch command: npm run watch, verify it builds the bundle and continues to listen without crashing.
  4. Load a page on the site using the assets
  5. Change an asset file, CSS, JS, etc and verify the command line shows the bundle rebuild (it will take about the same time production takes to build)
  6. Refresh the page and verify the changes show
  7. Close watch mode with Ctrl+C

Copy link

@miriamgoldman miriamgoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fully on FTD-FPI, and all works as expected.

@rleeson rleeson merged commit c8a8e40 into main Mar 25, 2024
@rleeson rleeson deleted the feature/watch branch March 25, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants