-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): tag kanisterio/build image as latest or dev_latest tag #2754
Conversation
Currently we have to update the build image tag every time we build a new one. This is because we sometimes build "dev" versions of this image for testing. Tagging 'latest' and 'dev_latest' makes it more convenient to use.
@@ -7,6 +7,14 @@ on: | |||
description: 'Image tag in the format vx.x.x' | |||
required: true | |||
type: string | |||
latest_tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this workflow is run automatically right?
how would someone decide if they want to tag the image to latest or something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this pipeline does not run automatically. workflow_dispatch
trigger can only be triggered manually and the inputs have to be set by the person triggering it.
dev_latest
should be set when building the test image (e.g. to test changes in the image)latest
should be set when building the image to be used for downstream users, such asrun_container.sh
and CI pipelines
I did not change the run_container.sh
in this PR because we don't have any latest
image yet.
PR looks good, but just for my understanding, if we talk about below from PR desc
where do we update the image tag? are you talking about updating it in the |
@viveksinghggits it needs to be updated in |
Change Overview
Currently we have to update the build image tag every time we build a new one. This is because we sometimes build "dev" versions of this image for testing.
Tagging 'latest' and 'dev_latest' makes it more convenient to use.
Pull request type
Please check the type of change your PR introduces:
Test Plan
Run the workflow to build
dev_latest
andlatest
tags.