refactor: Satisfy linter in zonesToRegion #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-sumin
commented
Mar 8, 2024
Comment on lines
-352
to
-355
| // TODO: gocritic rule below suggests to use regexp.MustCompile but it | ||
| // panics if regex cannot be compiled. We should add proper test before | ||
| // enabling this below so that no change to this regex results in a panic | ||
| r, _ := regexp.Compile("-?[a-z]$") //nolint:gocritic |
There was a problem hiding this comment.
This code will panic in any case, because error is ignored, and r will be nil in case of wrong regex. So, disabling linter and usage of Compile did not solve the issue with possible panic.
Anyway, now we do have unit test which will detect panic.
10 tasks
|
I've accidentally pushed original PR under wrong branch name. After renaming branch via GH, it has automatically closed existing PR, so I had to create new one. |
viveksinghggits
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
There was annotation which disables
gocritic. This linter could be enabled now, since we do have test which will detect panic.Also it fixes order of regions returned by
zonesToRegionsPull request type
Please check the type of change your PR introduces:
Issues
Test Plan