Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(goreleaser): add --pull flag to docker build when building images #2711

Merged
merged 2 commits into from
Mar 5, 2024
Merged

build(goreleaser): add --pull flag to docker build when building images #2711

merged 2 commits into from
Mar 5, 2024

Conversation

hairyhum
Copy link
Contributor

@hairyhum hairyhum commented Mar 1, 2024

Change Overview

Currently there are vulnerabilities in the images which should be fixed upstream. Make sure to build from the lates base images when running goreleaser.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

After merging elasticsearch and postgres-kanister-tools should pass container vulnerability scanning check

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@hairyhum
build(goreleaser): add --pull flag to docker build when building images
78e9f35 
Currently there are vulnerabilities in the images which should be fixed upstream.
Make sure to build from the lates base images when running goreleaser.
pavannd1
pavannd1 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hairyhum hairyhum added the kueue label Mar 5, 2024
@mergify mergify bot merged commit a0585c8 into master Mar 5, 2024
14 checks passed
@mergify mergify bot deleted the goreleaser-docker-pull branch March 5, 2024 23:01
hairyhum added a commit that referenced this pull request Mar 8, 2024
@hairyhum
build(ci): cleanup docker images in gha runner before building new im…
8396d5c 
…ages

Follow up to #2711 and #2727

Github keeps some image cache in the GHA runners which keeps around
base containers with vulnerabilities.

We can't use --pull because we use local-built tools image.
@hairyhum hairyhum mentioned this pull request Mar 8, 2024
Merged
10 tasks
hairyhum added a commit that referenced this pull request Mar 11, 2024
@hairyhum
build(ci): cleanup docker images in gha runner before building new im…
745c51a 
…ages

Follow up to #2711 and #2727

Github keeps some image cache in the GHA runners which keeps around
base containers with vulnerabilities.

We can't use --pull because we use local-built tools image.
hairyhum added a commit that referenced this pull request Mar 12, 2024
@hairyhum
build(ci): cleanup docker images in gha runner before building new im…
45acd13 
…ages (#2734)

Follow up to #2711 and #2727

Github keeps some image cache in the GHA runners which keeps around
base containers with vulnerabilities.

We can't use --pull because we use local-built tools image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairyhum @pavannd1