Enable misspell, nestif golang linter

[ankitjain235]

Change Overview

This PR enables misspell and nestif golang linters.

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes #issue-number

Test Plan

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

[mellon-collie]

Please rebase the commits to show logical progression, i.e., one commit could be to just enable go linting for misspell and the other commit could be for actually making the linting errors.

[mellon-collie]

Should we also raise separate PRs for enabling each of these linters and fixing them? For instance, one PR could be just for enabling misspell and fixing all the misspell lint issues.

[ankitjain235]

@mellon-collie I kept them this way so that we can track which changes were made for which enabled linter respectfully. It would be easy to track things for someone who is making changes in the same code path later.
When the PR is merged, then also the git blame would show this as part of linter enable PRs only and won't make users worry that this commit could be causing change in code behaviour. WDYT?

[mellon-collie]

@mellon-collie I kept them this way so that we can track which changes were made for which enabled linter respectfully. It would be easy to track things for someone who is making changes in the same code path later.
When the PR is merged, then also the git blame would show this as part of linter enable PRs only and won't make users worry that this commit could be causing change in code behaviour. WDYT?

Sure, that makes sense. Thanks for clarifying!

[PrasadG193]

I think it is fine to enable misspell in test file if doesn't require much changes

[ankitjain235]

It does require changes. Enabling these linters for tests would need a lot of extra work. I'll create a separate issue for the same?