Use bullseye #1705
Use bullseye #1705
Conversation
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
bathina2
requested review from
viveksinghggits,
pavannd1,
redgoat650 and
julio-lopez
| ADD docker/kanister-elasticsearch/image/esdump-setup.sh /esdump-setup.sh | ||
| RUN chmod +x /esdump-setup.sh && sync && /esdump-setup.sh | ||
| RUN apt update | ||
| RUN apt install -y nodejs npm bash curl |
There was a problem hiding this comment.
Was able to delete the shell script and directly call the install in the Dockerfile. Not sure why we used the shell script to begin with.
|
+1: LGTM, deferring to @pavannd1 to make the call here. |
| profile: newSecretProfile(), | ||
| }, | ||
| }) | ||
| // TODO: Add back after https://github.com/kanisterio/kanister/pull/1705 merges |
There was a problem hiding this comment.
There's an easier way to disable tests :)
You could just remove them from this line - https://github.com/kanisterio/kanister/blob/master/build/integration-test.sh#L28
There was a problem hiding this comment.
Ah didn't see the shell script. Just followed the go stack up to the register
Change Overview
This PR switches to using debian bullseye (stable) vs buster and other alpine invocations.
I updated the build image I pushed last week. So no need to update the Makefile to point to a new version.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan