-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Perl (perl.2) implementation #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ingydotnet sorry for the very slow reply (I've been unable to work on this project for the past couple of years but I'm am now able to again). If you're still interested in getting this merged upstream I would ask that you do the following:
- Is this implementation unique or interesting in some way compared to the existing perl implementation. If it is, then I'm happy to consider merging it. If not, I can add a link to your repo to the "Other Implementations" section of the top-level README.
- Rebase the code onto the current HEAD
- The recommended process has changed slightly: the eval_ast is no longer seperate from eval and macroexpand is not longer a standalone function. It would be good if you could update to follow the new structure.
- Make sure that the Github CI tests all pass for your implementation (this should happen more automatically now without needing me to manually create docker images as part of the process).
Greetings @kanaka! Boy do I have a lot to share with you! Best options are: |
@ingydotnet That's awesome stuff! I'll ping you on clojurians Slack. |
I think I can close this PR. There's nothing particularly novel about it iirc. I hope to make a YAMLScript implementation soon and submit a PR for that. That would bring me full circle!! |
I'm working on a YAML syntax Lisp called YAMLScript that will work in many languages.
I realized I really needed to learn how to implement a Lisp.
I found this project and completed the adventure.
This PR is for the perl.2 base implementation.
I'll be submitting a yamlscript implementation PR soon.