add tag_or_url for download_pretrained_model #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odels on googldrive
|
This says that imports are not in alphabetical order, do I need to fix it? Sorry, I am very new to pull requests. |
kan-bayashi
requested changes
May 14, 2022
parallel_wavegan/utils/utils.py
Outdated
Comment on lines
399
to
400
| tar.extract(member, f"{download_dir}/{tag_or_url}") | ||
| checkpoint_path = find_files(f"{download_dir}/{tag_or_url}", "checkpoint*.pkl") |
There was a problem hiding this comment.
Maybe using url as the directory name looks redundant.
Why don't you use tag for tag specification and URL id for URL specification?
Maybe we can define tag for each case e.g., tag=tag_or_url and tag=id_
There was a problem hiding this comment.
I like your second suggestion, I define a tag for each case, it looks cleaner.
Co-authored-by: Tomoki Hayashi <hayashi.tomoki@g.sp.m.is.nagoya-u.ac.jp>
kan-bayashi
reviewed
May 17, 2022
kan-bayashi
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the tag to
tag_or_url, now we can download other models not listed in thePRETRAINED_MODEL_LISTto be able to work with ParallelWaveGAN. For now the models should be uploaded to google drive